-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out proxied SplFixedArray handlers #18199
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing I'm not sure about, is removing the proxied object handle as this conflicts with the design for the container/offset RFC as it removes them. But this might be something that I should change it that implementation anyway.
I'm kinda confused by this statement. |
Although I would note that I would recommend against using real zend functions unless you find a way to reduce the overhead of internal function calls for those. (frameless?) |
The main issue is that internal classes need to take care to support child classes that may implement these interfaces. And I haven't found a good way around that. |
Ok. So let's wait for the proxy stuff and land the rest of this PR? WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. :)
This avoids checks if we know upfront that the instances are not inherited.
See individual commits