Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential leaks when writing to BIO fails #18186

Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from
Open

Fix potential leaks when writing to BIO fails #18186

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

When the BIO is created but writing fails, these can leak.

Detected using an experimental static analysis I'm developing.

@nielsdos nielsdos requested a review from bukka as a code owner March 29, 2025 22:42
@nielsdos
Fix potential leaks when writing to BIO fails
6abcdef 
When the BIO is created but writing fails, these can leak.
devnexen
devnexen approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIO_free doing null check, LGTM

@nielsdos
Copy link
Member Author

BIO_free doing null check, LGTM

Yeah, plus in other places in this file we do the same thing where we rely on the NULL check done by the OpenSSL API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: openssl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @devnexen