Modified the examples for mb_convert_kana, mb_detect_encoding, mb_encode_numericentity #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode_numericentity
| string(8) "SJIS-win" | ||
| string(5) "ASCII" | ||
| ]]> | ||
| </screen> |
There was a problem hiding this comment.
Hmm... I think confuse to put example of output.
The result of mb_detect_encoding is different in several version. Ref: https://3v4l.org/rf0FG
Because this function is tuning in heuristics. Maybe behavior changes to this function.
@alexdowad Do you have any opinion?
There was a problem hiding this comment.
I really would like that we add some huge warnings that this function is badly named and is far from accurate.
There was a problem hiding this comment.
@SakiTakamachi @Girgias Thanks. Looks good.
derickr
approved these changes
Mar 28, 2025
| The name of this function is misleading, it performs "guessing" rather than "detection". | ||
| </para> | ||
| <para> | ||
| The guesses are far from accurate, and cannot use this function to accurately detect |
There was a problem hiding this comment.
The guesses are far from accurate, and therefore you cannot use this function to accurately detect reads a little better to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.