Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 and C# 12 #250

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Update to .NET 8 and C# 12 #250

merged 8 commits into from
Feb 19, 2024

Conversation

Corniel
Copy link
Contributor

@Corniel Corniel commented Feb 16, 2024

As suggested in #249 , I took the liberty to update the target frameworks to .NET 8 (and for the published packages, .NET 6 is the secondary target), and use C# 12.

While at it, I updated the analyzer and Unit Test dependencies.

@Corniel
Copy link
Contributor Author

Corniel commented Feb 18, 2024

@phmonte I also converted al namespace declarations to file scoped ones.

@phmonte phmonte merged commit cead556 into phmonte:main Feb 19, 2024
6 checks passed
@Corniel Corniel deleted the net8 branch February 20, 2024 08:53
@Corniel
Copy link
Contributor Author

Corniel commented Feb 20, 2024

@phmonte I would expected you to have squach merged the branch, but you did not. Was that on purpose?

@phmonte
Copy link
Owner

phmonte commented Feb 20, 2024

The repository had squash disabled, I'll enable it, sorry!
I can do the squash manually.

@Corniel
Copy link
Contributor Author

Corniel commented Feb 20, 2024

No worries!

@phmonte
Copy link
Owner

phmonte commented Feb 20, 2024

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants