Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around longstanding core Talon issue in which notification windows aren't returned sometimes #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Work around longstanding core Talon issue in which notification windows aren't returned sometimes #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ def win_open(self, window):

def notification_groups(self):
ncui = ui.apps(pid=self.pid)[0]
for window in ncui.windows():
# XXX(nriley) Would use ncui.windows() but sometimes Talon loses track of them
for window in ncui.element.children.find(AXRole="AXWindow", max_depth=0):
for group in window.children.find(AXRole="AXGroup"):
if not (identifier := Notification.group_identifier(group)):
continue
Expand Down