Simplify the mecanism of Metacello #17983
Open
+179
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metacello is storing all the arguments given by users in an OrderedCollection with a selector associated. Once we want to execute an action, we instantiate an executor and it will perform all those selectors. This makes the code a bit weird. I propose to simplify it by directly instantiating an executor and delegating all the configuration to it. This makes the code more straightforward. I also updated a little the comment
|
I also introduced MetacelloAbstractSpecGenerator. Before we had the BaselineSpecGenerator and ConfigurationSpecGenerator inheriting from the ProjectSpecGenerator. But this class is neither an abstract class or a generalization of the other two. The three of them should be on the same level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metacello is storing all the arguments given by users in an OrderedCollection with a selector associated. Once we want to execute an action, we instantiate an executor and it will perform all those selectors.
This makes the code a bit weird. I propose to simplify it by directly instantiating an executor and delegating all the configuration to it.
This makes the code more straightforward.
I also updated a little the comment and removed dead code