Fixed the duplicate class refactoring wrong message

[AlexisCnockaert]

Fixes #17518

• Indeed there is a <1?:not > in #isGlobal: in: that was putting a "not" in the linked issue but because we evaluated (RBCondition alreadyExistGlobal: className in: self model) not. the not was put in the wrong cases
• I created a new method to handle it to not change anything in #isGlobal: in: to not break something

[balsa-sarenac]

I think you should just update the error message in the isGlobal: in: .
In my opinion this is just code duplication in order to have different error message.

[balsa-sarenac]

Check other methods how they introduced support for not. Make the error message you created the default in the old method. Make sure it works with not as well.

[AlexisCnockaert]

Ok got it thanks :)

[Ducasse]

I was thinking that we can integrate that now and we should convert everything to our condition and they should offer the possibility to change the message. I started to do that.

[balsa-sarenac]

I agree, but this is easy to fix, I would suggest fixing now, it will be easier when transitioning later

[Ducasse]

Ok let us fix it now :)
You convinced me.

[balsa-sarenac]

Let's move on with this text, but this error message doesn't support not message, so we're creating a new issue.
I have to load the code to give some better suggestion on how to fix this. I'll try to find some time during next week.