Move #hasBindingThatBeginsWith: to Shout #17932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also removed a dead method on OCVariableNode Fixes pharo-project#17902
jecisc
force-pushed
the
misc/hasBindingThatBeginsWith
branch
from
5542f2d to
4727d36
Compare
jecisc
added
the
Status: Need more work
|
I'll need to work of this PR because apparently Shout-Tests is loaded before the test on SystemEnvironment which seems weird to me. Tooling tests should be loaded after kernel tests. |
|
Tx cyril! |
jecisc
added
Status: Tests passed please review!
and removed
Status: Need more work
|
Looks like ther is still a conflict |
|
I did a merge |
Ducasse
added
the
Status: Need more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed a dead method on OCVariableNode
Fixes #17902