Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasBindingThatBeginsWith: aString should be packaged with Shout #17902

Open
Ducasse opened this issue Feb 27, 2025 · 0 comments · May be fixed by #17932
Open

hasBindingThatBeginsWith: aString should be packaged with Shout #17902

Ducasse opened this issue Feb 27, 2025 · 0 comments · May be fixed by #17932
Labels
Type: Cleanup

Comments

@Ducasse
Copy link
Member

Ducasse commented Feb 27, 2025

hasBindingThatBeginsWith: aString is exclusively used by

styleNameIn: aVariableNode

	^ (aVariableNode scope hasBindingThatBeginsWith: self name)
		  ifTrue: [ #incompleteIdentifier ]
		  ifFalse: [ #undefinedIdentifier ]

All the methods and all the tests of such features should be placed in the Shout package
jecisc added a commit to jecisc/pharo that referenced this issue Mar 5, 2025
@jecisc
Move #hasBindingThatBeginsWith: to Shout
751ce4e 
I also removed a dead method on OCVariableNode

Fixes pharo-project#17902
@jecisc jecisc linked a pull request Mar 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup
Projects
Compiler and AST
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move #hasBindingThatBeginsWith: to Shout jecisc/pharo
1 participant
@Ducasse