Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial test of snippet #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barryvdh
Copy link
Contributor

This is just a proof of concept to implement https://github.com/Yoast/YoastSEO.js

I had some trouble compiling the SCSS from the package, so copied that manually.

Not sure how to best integrate this. It's a lot more extensive, but that needs the 'article content' of the page, which I'm not sure how to detect.
In the current form, you can just go to kupo.app/snippet?url=http://mysite.com and get the preview from the snippet.

Also, compiling with yarn doesn't work, only in watch mode :/ Due to error in YoastSEO

@@ -4,3 +4,32 @@
Route::get('/', function () {
return view('app');
});

Route::get('snippet', function (\Illuminate\Http\Request $request ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could move this to a Controller to avoid overloading the routes file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants