Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12013 Fix scrapeconfig generation for rds exporter. #3293

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Nov 8, 2024

PMM-12013

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested a review from a team as a code owner November 8, 2024 14:32
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team November 8, 2024 14:32
@BupycHuk BupycHuk enabled auto-merge (squash) November 8, 2024 14:32
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.51%. Comparing base (8cb6278) to head (755d580).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3293      +/-   ##
==========================================
- Coverage   43.54%   43.51%   -0.04%     
==========================================
  Files         365      365              
  Lines       44150    44151       +1     
==========================================
- Hits        19226    19213      -13     
- Misses      23242    23256      +14     
  Partials     1682     1682              
Flag Coverage Δ
admin 11.54% <ø> (+0.04%) ⬆️
agent 51.83% <ø> (-0.15%) ⬇️
managed 45.26% <100.00%> (+<0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk merged commit 9fcf353 into v3 Nov 8, 2024
32 checks passed
@BupycHuk BupycHuk deleted the PMM-12013-fix-scrapeconfig-generation branch November 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants