Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13392 Strip agent status prefix in json #3276

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 31, 2024

PMM-13392

Link to the Feature Build: SUBMODULES-3754

This PR contains also a few output formatting fixes, which make table output cleaner, providing equal spacing.

@ademidoff ademidoff marked this pull request as ready for review October 31, 2024 15:27
@ademidoff ademidoff requested a review from a team as a code owner October 31, 2024 15:27
@ademidoff ademidoff requested review from idoqo, JiriCtvrtka and BupycHuk and removed request for a team October 31, 2024 15:27
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.54%. Comparing base (9fcf353) to head (5a026a0).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
admin/agentlocal/agentlocal.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #3276   +/-   ##
=======================================
  Coverage   43.54%   43.54%           
=======================================
  Files         365      365           
  Lines       44150    44150           
=======================================
+ Hits        19224    19227    +3     
+ Misses      23246    23241    -5     
- Partials     1680     1682    +2     
Flag Coverage Δ
admin 11.51% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff enabled auto-merge (squash) November 8, 2024 14:56
@ademidoff ademidoff merged commit b70db18 into v3 Nov 8, 2024
14 checks passed
@ademidoff ademidoff deleted the PMM-13392-strip-agent-status-prefix-json branch November 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants