PS-9151: Fix build with WITH_SSL=openssl11 [trunk] #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-9151 The opensslpp build fails with "Could NOT find OpenSSL" error in case WITH_SSL=openssl11 is used. The authentication_fido plugin build fails because of unmet fido2 dependencie. To fix the issue: - Remove find_package(OpenSSL REQUIRED) in opensslpp/CMakeLists.txt. All openssl related preparations are done inside ssl.cmake. - Update ssl.cmake to always create OpenSSL::SSL and OpenSSL::Crypto imported libs. For all possible WITH_SSL values: system, openssl11, /path/to/openssl. - Unset WITH_PERCONA_AUTHENTICATION_FIDO in case the server is being built with openssl version incompatible with fido2 lib. - Added missing WITH_PERCONA_AUTHENTICATION_FIDO in conditions related to fido2 lib handling. - Use ext::curl interface library in keyring_vault and keyring_kms cmake.
oleksandr-kachan
force-pushed
the
PS-9151-trunk
branch
from
d311bf2
to
0766d9c
Compare
oleksandr-kachan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9151
Adding some missing parts in cmake files:
All openssl related preparations are done inside ssl.cmake.
built with openssl version incompatible with fido2 lib.