Skip to content

K8SPG-737: expose /pgdata mountpoint for node_exporter #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Mar 31, 2025

K8SPG-737 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-737

DESCRIPTION

Problem:
pmm-client's node_exporter does not send metrics for the /pgdata mount point

Cause:
The /pgdata volume is not mounted in the instance pod. In addition, even if the volume is mounted, node_exporter will not collect usage data for /pgdata unless .spec.shareProcessNamespace is set to false.

Solution:
Add /pgdata volume mount to the instance pods and replace .spec.shareProcessNamespace to false

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@egegunes egegunes added this to the 2.7.0 milestone Mar 31, 2025
@pooknull pooknull marked this pull request as ready for review April 7, 2025 16:30
egegunes
egegunes previously approved these changes Apr 8, 2025
ReadOnly: true,
},
}
if pgc.CompareVersion("2.7.0") >= 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip this part with the compare version for PMM3 given we are introducing it in the 2.7 as a whole.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
monitoring-pmm3 passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 20 out of 20

commit: 496af0d
image: perconalab/percona-postgresql-operator:PR-1113-496af0db8

@hors hors merged commit 6ac9ad4 into main Apr 8, 2025
18 checks passed
@hors hors deleted the dev/K8SPG-737 branch April 8, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants