K8SPG-708 replace ready/live probe http check with custom command, change pg entrypoint #1099
+3,052
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
commented
Mar 24, 2025
internal/patroni/reconcile.go
Outdated
Comment on lines
151
to
152
| container.LivenessProbe.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/usr/local/bin/postgres-liveness-check.sh"}, |
There was a problem hiding this comment.
Maybe we want to do this change only for >2.7.0 🤔
gkech
requested review from
hors,
egegunes,
pooknull,
nmarukovich,
jvpasinatto and
eleo007
as code owners
egegunes
requested changes
Mar 25, 2025
egegunes
previously approved these changes
Mar 26, 2025
nmarukovich
reviewed
Mar 26, 2025
nmarukovich
reviewed
Mar 26, 2025
nmarukovich
reviewed
Mar 26, 2025
gkech
changed the title
egegunes
previously approved these changes
Apr 1, 2025
|
Note that this PR has base branch |
nmarukovich
reviewed
Apr 8, 2025
| @@ -178,6 +178,7 @@ get_cr() { | |||
| .spec.users += [{"name":"postgres","password":{"type":"AlphaNumeric"}}] | | |||
| .spec.users += [{"name":"'${cr_name}'","password":{"type":"AlphaNumeric"}}] | | |||
| .spec.image = "'$IMAGE_POSTGRESQL'" | | |||
| .spec.initContainer.image = "perconalab/percona-postgresql-operator:K8SPG-708-12" | | |||
There was a problem hiding this comment.
should we fix this image with main tag?
There was a problem hiding this comment.
I think it is just for tests. As soon as we see that all tests are ok we need to remove it at all
There was a problem hiding this comment.
yes correct, we have it only for these tests to work and to confirm that the PR is alright. We will change it on a followup PR after we merge.
commit: 41fa93d |
egegunes
approved these changes
Apr 9, 2025
nmarukovich
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
We are changing the probes from direct requests to patroni's restful api to a custom command so that we can get more flexibility on what can be executed for the live/ready checks of the pg container. For now this is needed so that we can introduce a sleep forever feature.
Deleted related PR: percona/percona-docker#1148
We are also introducing a new entrypoint for the database container which is defined in the percona-docker repo for now.
Testing sleep forever
Checking the creation of the /tmp/postgres file and verifying that
pg_ctl -D /pgdata/pg17 startstarts as expectedCause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability