Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stdlib url<->path conversion #3364

Merged
merged 3 commits into from
Dec 31, 2024
Merged

fix: use stdlib url<->path conversion #3364

merged 3 commits into from
Dec 31, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (e29740f) to head (991f21f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/backends.py 66.66% 2 Missing ⚠️
src/pdm/models/requirements.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   85.23%   85.23%   -0.01%     
==========================================
  Files         112      112              
  Lines       11470    11467       -3     
  Branches     2510     2510              
==========================================
- Hits         9777     9774       -3     
  Misses       1168     1168              
  Partials      525      525              
Flag Coverage Δ
unittests 85.03% <88.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming linked an issue Dec 31, 2024 that may be closed by this pull request
1 task
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit f865e56 into main Dec 31, 2024
21 checks passed
@frostming frostming deleted the fix/url-path branch December 31, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.14, pathname2url does not add //
1 participant