Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: derive Eq and PartialEq for SeekMode #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: derive Eq and PartialEq for SeekMode #361

wants to merge 1 commit into from

Conversation

roderickvd
Copy link
Contributor

This is useful to be able to do:

if seek_mode == SeekMode::Accurate { ... }

instead of the less readable:

if matches!(seek_mode, SeekMode::Accurate) { ... }

Ran into this as we're improving sample-accurate seeking in Rodio: RustAudio/rodio#697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roderickvd