Hotfix: force version number during macros feature resolution #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces a version number during macro resolution with the
macrosfeature. This hopefully will resolve #641.The ultimate fix is to decouple Rust Decimal from the macros altogether. This requires a bit of a refactor which makes this a little more than a revision bump however (though will definitely look into for 1.35).
If this fails to resolve the issue still then I will pull the feature (since it is new) and reintroduce it in 1.35, however I have a strong suspicion this may help resolve the circular dependency since we lock it to
1.33.1(as opposed to before it was^1.31).