Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken stream on normal flow error #205

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix broken stream on normal flow error #205

merged 1 commit into from
Feb 12, 2025

Conversation

Chocobozzz
Copy link
Contributor

This breaks chokidar v4 because the stream never ends

@paulmillr
Copy link
Owner

Do you have a test for that?

@Chocobozzz
Copy link
Contributor Author

I added a test

I also removed batch-- as we don't send data in the stream

@paulmillr paulmillr merged commit 76b1e11 into paulmillr:master Feb 12, 2025
15 checks passed
@Chocobozzz
Copy link
Contributor Author

Can you create a patch release to fix chokidar v4?

@Chocobozzz
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chocobozzz @paulmillr