[bug] check error on FillParameters

paulmey · Jun 3, 2019 · 7b6ed8c · 7b6ed8c
1 parent da80784
commit 7b6ed8c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/builder/azure/chroot/builder.go b/builder/azure/chroot/builder.go
@@ -249,7 +249,10 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack
 		return nil, errors.New("the azure-chroot builder only works on Linux environments")
 	}
 
-	b.config.ClientConfig.FillParameters()
+	err := b.config.ClientConfig.FillParameters()
+	if err != nil {
+		return nil, fmt.Errorf("error setting Azure client defaults: %v", err)
+	}
 	azcli, err := client.New(b.config.ClientConfig, ui.Say)
 	if err != nil {
 		return nil, fmt.Errorf("error creating Azure client: %v", err)
@@ -281,12 +284,9 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack
 	}
 
 	state.Put("instance", info)
-	if err != nil {
-		return nil, err
-	}
 
 	// Build the steps
-	steps := []multistep.Step{}
+	var steps []multistep.Step
 
 	if b.config.FromScratch {
 		steps = append(steps,