Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Qadence Transition #34

Merged
merged 14 commits into from
Jan 28, 2025
Merged

[Draft] Qadence Transition #34

merged 14 commits into from
Jan 28, 2025

Conversation

sungwoo-pasqal
Copy link
Collaborator

@sungwoo-pasqal sungwoo-pasqal commented Jan 14, 2025

Building Qadence transition document using qadence2.legacy codes
Opening draft PR for sharing and updating purposes.
...
Completed simple transition guide of Qadence2.

@sungwoo-pasqal sungwoo-pasqal added the documentation Improvements or additions to documentation label Jan 14, 2025
@sungwoo-pasqal sungwoo-pasqal self-assigned this Jan 14, 2025
@Doomsk Doomsk changed the title Qadence Transition [Draft] Qadence Transition Jan 16, 2025
@sungwoo-pasqal sungwoo-pasqal marked this pull request as ready for review January 24, 2025 16:47
Copy link
Member

@pimvenderbosch pimvenderbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sungwoo-pasqal,

Thank you for the transition document. I left a few minor remarks.

docs/transition.md Outdated Show resolved Hide resolved
docs/transition.md Outdated Show resolved Hide resolved
docs/transition.md Show resolved Hide resolved
docs/transition.md Outdated Show resolved Hide resolved
docs/transition.md Outdated Show resolved Hide resolved
@sungwoo-pasqal
Copy link
Collaborator Author

Thanks @pimvenderbosch. I applied the comments into the changes.

Copy link
Member

@pimvenderbosch pimvenderbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sungwoo-pasqal, ready for merging!

@sungwoo-pasqal sungwoo-pasqal merged commit 2f2e632 into main Jan 28, 2025
6 checks passed
@sungwoo-pasqal sungwoo-pasqal deleted the sa/transition branch January 28, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants