-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place coding examples with legacy-like structure #19
Conversation
# Conflicts: # README.md
add example
add example
Signed-off-by: Doomsk <[email protected]>
One question, if you consider this to be a "legacy-like" structure, is there some specific new structure that should be used instead? If yes, it would be good to have the examples in that format as well. |
add legacy operations Signed-off-by: Doomsk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an intermediary review. Minor comments there otherwise LGTM.
Signed-off-by: Doomsk <[email protected]>
Signed-off-by: Doomsk <[email protected]>
# Conflicts: # examples/pyq_compiler.py # pyproject.toml
@jpmoutinho I think it makes sense then to address them in the documentation, let me know what you think |
Signed-off-by: Doomsk <[email protected]>
Signed-off-by: Doomsk <[email protected]>
Signed-off-by: Doomsk <[email protected]>
add docstrings Signed-off-by: Doomsk <[email protected]>
This PR will close #30 |
Signed-off-by: Doomsk <[email protected]>
# Conflicts: # pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Doomsk! Not much to say, I think this looks good as a starting point and when we can build from here :)
Add example given by João to compare with current Qadence 1 code:
and Qadence 2: