Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Tensor representation of controlled operations with qubit support order #40

Merged
merged 12 commits into from
Feb 12, 2025
Merged

[Bugfix] Tensor representation of controlled operations with qubit support order #40

merged 12 commits into from
Feb 12, 2025

Conversation

chMoussa
Copy link
Collaborator

Resolves #35

@chMoussa chMoussa added the bug Something isn't working label Jan 10, 2025
@chMoussa chMoussa self-assigned this Jan 10, 2025
@chMoussa chMoussa marked this pull request as ready for review January 10, 2025 12:49
RolandMacDoland
RolandMacDoland reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @chMoussa. Few comments from my side.

horqrux/primitive.py Outdated Show resolved Hide resolved
horqrux/primitive.py Show resolved Hide resolved
horqrux/utils.py Show resolved Hide resolved
horqrux/utils.py Show resolved Hide resolved
horqrux/utils.py Outdated Show resolved Hide resolved
horqrux/utils.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (c61e84d) to head (a6de260).

Files with missing lines Patch % Lines
horqrux/utils.py 75.75% 8 Missing ⚠️
horqrux/primitive.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   90.17%   89.91%   -0.26%     
==========================================
  Files          19       19              
  Lines        1058     1121      +63     
==========================================
+ Hits          954     1008      +54     
- Misses        104      113       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mlahariya
mlahariya reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@mlahariya mlahariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments.

horqrux/utils.py Show resolved Hide resolved
horqrux/shots.py Show resolved Hide resolved
@chMoussa chMoussa merged commit f8d0cae into main Feb 12, 2025
6 checks passed
@chMoussa chMoussa deleted the cm/try_controls branch February 12, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlahariya mlahariya mlahariya approved these changes

@RolandMacDoland RolandMacDoland Awaiting requested review from RolandMacDoland

Assignees

@chMoussa chMoussa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Controlled operations are not right
4 participants
@chMoussa @codecov-commenter @RolandMacDoland @mlahariya