-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emu-SV] Monkey patch and qubit density sparse apply #6
Conversation
run linter and tests via github actions
Prepare the code for autosave, which needs to be able to save the state of the simulation for later resuming, even inside tdvp. For this, the different steps of the tdvp logic are brought inside mps_backend_impl. Baths are stored inside this same class. Right baths from a right-left swipe are reused in the following left-right swipe, provided the hamiltonian doesn't change, which occurs in the absence of lindbladian noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comments on the code, I have an additional question:
Do you want to do the correlation matrix and energy related observables in this MR also, or in a separate one? The approach you take here is good, so doing the others will be kind of the same.
I will do it in a separate MR. I prefere having a small MR that is easy to review |
Related to issue #7
Monkey patching the apply method of Qubit Density callback. The custom apply is "sparse" implementation of the following operator:
where
New/updates
custom_applies.py
script where I will store the custom apply methodsqubit_density
callback. The same is emu-sv. Both results should be same upto certain tolerance