Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emu-SV] Monkey patch and qubit density sparse apply #6

Merged
merged 23 commits into from
Jan 16, 2025

Conversation

murogrande
Copy link
Contributor

@murogrande murogrande commented Jan 14, 2025

Related to issue #7
Monkey patching the apply method of Qubit Density callback. The custom apply is "sparse" implementation of the following operator:

$I \otimes I \otimes n_i\otimes ... ,$
where $n_i$ is the number operator

New/updates

  • emu_sv folder: custom_applies.py script where I will store the custom apply methods
  • test: emu-mps: I added a test related to qubit_density callback. The same is emu-sv. Both results should be same upto certain tolerance

a-quelle and others added 12 commits January 8, 2025 13:16
run linter and tests via github actions
Prepare the code for autosave, which needs to be able to
save the state of the simulation for later resuming, even
inside tdvp.

For this, the different steps of the tdvp logic are brought
inside mps_backend_impl.
Baths are stored inside this same class.
Right baths from a right-left swipe are reused in the following
left-right swipe, provided the hamiltonian doesn't change, which
occurs in the absence of lindbladian noise.
@murogrande murogrande self-assigned this Jan 14, 2025
@murogrande murogrande marked this pull request as ready for review January 14, 2025 13:34
@murogrande murogrande added the in progress issue: work in progress label Jan 14, 2025
Copy link
Collaborator

@a-quelle a-quelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments on the code, I have an additional question:
Do you want to do the correlation matrix and energy related observables in this MR also, or in a separate one? The approach you take here is good, so doing the others will be kind of the same.

@murogrande
Copy link
Contributor Author

murogrande commented Jan 14, 2025

Apart from my comments on the code, I have an additional question: Do you want to do the correlation matrix and energy related observables in this MR also, or in a separate one? The approach you take here is good, so doing the others will be kind of the same.

I will do it in a separate MR. I prefere having a small MR that is easy to review

@murogrande murogrande merged commit 6c1392f into main Jan 16, 2025
2 checks passed
@murogrande murogrande deleted the mm/monky_patch branch January 16, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress issue: work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants