Docker support #19
Open
Docker support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job, beat me by a few hours. I was building on alpine; maybe worth trying to reduce the overall size? |
|
Thanks! I was looking for better compatibility but perhaps makes sense to switch to alpine at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note - first time I create a dockerfile.
Need to add credentials in docker compose. Scripts are part of dockerfile so they are not needed in package.json.
I was able to start the webapp in port 8100 but I get errors when uploading files. The same errors appear here https://vault.pash.city so I guess it is not an issue of the docker image.