update batch size in session config

[nikhilsinhaparseable]

current: 1000000
update to 20000

this helps in query performance as larger batch size consumes more memory and slows down performance

with this change, parseable's clickbench numbers are [182,75,75]

Summary by CodeRabbit

• New Features
  • Introduced a configurable batch size for query execution, allowing users to set it via environment variables or command-line arguments.
  • Default batch size is now set to 20000.

[coderabbitai]

Walkthrough

The pull request updates the batch size configuration within the create_session_context method of the Query struct. The hardcoded batch size of 1000000 has been replaced with a configurable option, PARSEABLE.options.execution_batch_size, which can be set via an environment variable. Additionally, a new field execution_batch_size has been added to the Options struct in src/cli.rs, allowing it to be specified through command-line arguments. The default value for the batch size is now 20000.

Changes

File(s)	Change Summary
src/query/mod.rs	Updated create_session_context method to replace hardcoded batch size of 1000000 with configurable option.
src/cli.rs	Added new field execution_batch_size to Options struct, allowing batch size to be set via command-line args.

Possibly related PRs

• fix: multi threaded query execution #1220: Related changes in the execute method of the Query struct focus on enhancing query execution configurations.
• update to SessionConfig #1234: Modifies the same method to introduce a different configuration option, directly relating to batch size management.

Suggested reviewers

• de-sh
• nitisht

Poem

I'm a nimble little rabbit, hopping through the code,
Tweaking batch sizes in my humble abode.
From a million to twenty-thou,
Records now dance in a smaller row.
With a skip and a hop, I celebrate this mode! 🐰

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/query/mod.rs (1)

114-114: Approve batch size reduction for improved performance.

The change from 1,000,000 to 8,192 aligns with the PR objective to optimize memory consumption and improve query performance. According to the PR, this has yielded improved clickbench metrics [181, 68, 68].

Consider adding a comment explaining why 8,192 was chosen as the optimal batch size and what performance benefits it provides compared to the previous value:

-            .with_batch_size(8192);
+            // Use 8192 as the batch size (instead of 1000000) to reduce memory consumption
+            // and improve query performance. Benchmark results: [181, 68, 68]
+            .with_batch_size(8192);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6919a5c and cb370bb.

📒 Files selected for processing (1)

• src/query/mod.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: coverage
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/cli.rs (1)

273-279: Looks good, consider enhancing the help text

The new execution_batch_size parameter is correctly implemented, following the established patterns in the codebase. Reducing the default batch size from 1,000,000 to 20,000 should improve query performance as indicated in the PR objectives.

However, the help text could be more descriptive to guide users on the purpose and impact of this setting. Consider expanding it to explain how this parameter affects memory usage and query performance.

-        help = "batch size for query execution"
+        help = "Batch size for query execution - lower values reduce memory usage but may increase processing overhead, higher values consume more memory but may improve throughput"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e28a445 and 0c726f7.

📒 Files selected for processing (2)

• src/cli.rs (1 hunks)
• src/query/mod.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/query/mod.rs

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: coverage