Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix flaky sendVerificationEmail tests #9692

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 2, 2025

Pull Request

Issue

sendVerificationEmail runs in the background so you need to wait until it's finished

Closes: #9274
Closes: #9275
Closes: #9276

Approach

  • Use deferred promises
  • Remove jasmine.timeout where needed
  • Refactor tests to use async / await

Copy link

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (257be69) to head (e5f4663).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9692   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         187      187           
  Lines       15066    15066           
=======================================
  Hits        13974    13974           
  Misses       1092     1092           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment