Skip to content

feat: Add ZeptoMail support #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 19, 2024
Merged

Conversation

ashish-naik
Copy link
Contributor

@ashish-naik ashish-naik commented Oct 13, 2024

  • [x ] I am not disclosing a vulnerability.
  • I am creating this PR in reference to an issue.

Issue Description

Closes: #97

Approach

Add payload converter method to convert payload to ZeptoMail format.

TODOs before merging

  • Add test cases
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Oct 13, 2024

Thanks for opening this pull request!

- handling of v1.1
- tests for v1.1
- code cleanup
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter settings seem to be quite weak, I found a few code style issues (spaces, missing brackets, semicolons, etc). I may have missed some, could you look through all the changes again to make sure the style is consistent?

Copy link

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

Copy link

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

@ashish-naik
Copy link
Contributor Author

Thanks for your patience. I have tried to fix the issues. Lot of new things for me.

@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2024

Thanks, let's see the CI...

@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2024

Fixed codecov in #99 to make the CI pass.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9af92ae). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #98   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?       159           
  Branches        ?         0           
========================================
  Hits            ?       159           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza closed this Oct 18, 2024
@mtrezza mtrezza reopened this Oct 18, 2024
@mtrezza mtrezza merged commit f211b99 into parse-community:main Oct 19, 2024
8 checks passed
@ashish-naik
Copy link
Contributor Author

Thanks @mtrezza for helping me. This is my first contribution.

@mtrezza
Copy link
Member

mtrezza commented Oct 19, 2024

I will fix the release workflow in the next days, so that this feature can be released on npm.

parseplatformorg pushed a commit that referenced this pull request Oct 20, 2024
# [4.1.0](4.0.0...4.1.0) (2024-10-20)

### Features

* Add ZeptoMail support ([#98](#98)) ([f211b99](f211b99))
@parseplatformorg
Copy link

🎉 This change has been released in version 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZeptoMail support
3 participants