-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Add ZeptoMail support #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
- handling of v1.1 - tests for v1.1 - code cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter settings seem to be quite weak, I found a few code style issues (spaces, missing brackets, semicolons, etc). I may have missed some, could you look through all the changes again to make sure the style is consistent?
The branch Pull requests are usually opened against the default branch |
The branch Pull requests are usually opened against the default branch |
Thanks for your patience. I have tried to fix the issues. Lot of new things for me. |
Thanks, let's see the CI... |
Fixed codecov in #99 to make the CI pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 159
Branches ? 0
========================================
Hits ? 159
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Manuel <[email protected]>
Thanks @mtrezza for helping me. This is my first contribution. |
I will fix the release workflow in the next days, so that this feature can be released on npm. |
# [4.1.0](4.0.0...4.1.0) (2024-10-20) ### Features * Add ZeptoMail support ([#98](#98)) ([f211b99](f211b99))
🎉 This change has been released in version 4.1.0 |
Issue Description
Closes: #97
Approach
Add payload converter method to convert payload to ZeptoMail format.
TODOs before merging