Moved presets to the testnet runtimes #5327

bkontur · 2024-08-12T14:56:47Z

It is a first step for switching to the frame-omni-bencher for CI.

This PR includes several changes related to generating chain specs plus:

pallet assigned_slots fix missing #[serde(skip)] for phantom
pallet paras_inherent benchmark fix - cherry-picked from fix rococo-dev bench #5688
migrates get_preset to the relevant runtimes
fixes Rococo genesis presets - does not work https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249
fixes Rococo benchmarks for CI
migrate westend genesis
remove wococo stuff

Closes: #5680

Follow-ups

Fix for frame-omni-bencher [benchmarking] Reset to genesis storage after each run #5655
Enable new short-benchmarking CI - Enable GHA short benchmarks with frame-omni-bencher #5706
Remove gitlab pipelines for short benchmarking
refactor all Cumulus runtimes to use get_preset - Refactor polkadot-parachain-bin chain-specs for cumulus runtimes and move genesis presets to the runtimes get_preset #5704
Refactor get_account_id_from_seed / get_from_seed to one common place #5705
Only customized fields in preset json blob? #5700
Backport to the stable

bkontur · 2024-08-30T13:37:37Z

@michalkucharczyk I just saw your branch origin/mku-asset-hub-rococo-preset and your PR, I think you are doing the same as I here, but in this PR I've already refactored some of the testnet AssetHubs/BridgeHubs.

What if I update this branch to actual master and then we could merge your PR's changes here and then you could also continue with other runtimes here? wdyt?

michalkucharczyk · 2024-08-30T14:14:37Z

@michalkucharczyk I just saw your branch origin/mku-asset-hub-rococo-preset and your PR, I think you are doing the same as I here, but in this PR I've already refactored some of the testnet AssetHubs/BridgeHubs.

What if I update this branch to actual master and then we could merge your PR's changes here and then you could also continue with other runtimes here? wdyt?

Can we just merge my PR to master (as it is ready to be merged) and then you can merge master to this PR?
I am not sure who will work on reworking rest of runtimes as I am still invoved in #4639 .

michalkucharczyk · 2024-08-30T14:17:19Z

cumulus/polkadot-parachain/src/chain_spec/asset_hubs.rs

-		testnet_parachains_constants::westend::currency::UNITS * 1_000_000,
-		1000.into(),
-	))
+	.with_genesis_config_patch(asset_hub_westend_development_genesis(para_id.into()))


You shall use: with_genesis_config_preset_name.

This would allow to fetch the preset from the wasm blob, w/o necessity to natively compile the runtime.

I noticed the same in polkadot-fellows/runtimes#379 (review)

yes, I saw that fellows comment, it is still in my TODOs :)

bkontur · 2024-08-30T14:25:56Z

@michalkucharczyk I just saw your branch origin/mku-asset-hub-rococo-preset and your PR, I think you are doing the same as I here, but in this PR I've already refactored some of the testnet AssetHubs/BridgeHubs.
What if I update this branch to actual master and then we could merge your PR's changes here and then you could also continue with other runtimes here? wdyt?

Can we just merge my PR to master (as it is ready to be merged) and then you can merge master to this PR? I am not sure who will work on reworking rest of runtimes as I am still invoved in #4639 .

ok, let's merge your and I will adjust and continue here with other testnets

michalkucharczyk · 2024-08-30T14:26:43Z

@michalkucharczyk I just saw your branch origin/mku-asset-hub-rococo-preset and your PR, I think you are doing the same as I here, but in this PR I've already refactored some of the testnet AssetHubs/BridgeHubs.
What if I update this branch to actual master and then we could merge your PR's changes here and then you could also continue with other runtimes here? wdyt?

Can we just merge my PR to master (as it is ready to be merged) and then you can merge master to this PR? I am not sure who will work on reworking rest of runtimes as I am still invoved in #4639 .

ok, let's merge your and I will adjust and continue here with other testnets

Thank you

michalkucharczyk · 2024-08-30T14:27:59Z

Not sure if you are interested - there is one more I plan to merge soon: #4739

paritytech-cicd-pr · 2024-09-01T21:12:22Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7209375

paritytech-cicd-pr · 2024-09-01T21:12:22Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7209377

bkontur · 2024-09-02T11:11:56Z

bot fmt

command-bot · 2024-09-02T11:12:02Z

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7214774 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-3568b7dd-c695-4ae7-a3d4-30e9d1fb4ca3 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-02T11:13:51Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7214774 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7214774/artifacts/download.

cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs

bkontur · 2024-09-13T11:30:14Z

why not in GHA?

@mordamax You mean why not using short benchmarks from GHA with frame-omni-bencher?
Because we need to first merge: #5655 and then enabled shorts GHA - it is a follow up

mordamax

understood, although I think we could migrate rococo/westend already to omni anyways, as only some of the bridge ones fail until those fix?

…testnets

bkontur · 2024-09-13T12:43:29Z

Basically we need sth like this:

Let's create an issue for this. We can discuss it there if we want/need this.

-> #5700

@michalkucharczyk I could possibly also revert using RuntimeGenesisConfig and revert back json for the main level, and we can switch to RuntimeGenesisConfig as a part of #5700, wdyt revert or leave it as it is?

michalkucharczyk · 2024-09-13T12:57:21Z

Basically we need sth like this:

Let's create an issue for this. We can discuss it there if we want/need this.

-> #5700

@michalkucharczyk I could possibly also revert using RuntimeGenesisConfig and revert back json for the main level, and we can switch to RuntimeGenesisConfig as a part of #5700, wdyt revert or leave it as it is?

Honestly, I don't know.
We never assumed any kind of compatibility between presets across different versions - so small chances that sth will be broken. With this in mind I think we can leave them as is, and try to align everything in #5700.

cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs

polkadot/runtime/rococo/src/genesis_config_presets.rs

michalkucharczyk

LGTM.

Would be nice to add some tests verifying that presets are actually convertible to genesis storage - sample approach given here:

polkadot-sdk/substrate/test-utils/runtime/src/lib.rs

Line 1363 in 9307d99

fn build_config_from_json_works() {

But this could be done in follow-up, especially in context of #5700.

prdoc/pr_5327.prdoc

…testnets

michalkucharczyk · 2024-09-18T08:53:19Z

substrate/primitives/genesis-builder/src/lib.rs

@@ -66,6 +66,10 @@ pub type PresetId = sp_runtime::RuntimeString;
 /// [`GenesisBuilder`] interface.
 pub const DEV_RUNTIME_PRESET: &'static str = "development";

+/// The default `local-testnet` preset used to communicate with the runtime via
+/// [`GenesisBuilder`] interface.
+pub const LOCAL_TESTNET_RUNTIME_PRESET: &'static str = "local_testnet";


Sorry for nit-picking: maybe it would good to add some note on which preset is mandatory and which is optional? (Having these predefined names maybe somewhat confusing for runtime's maintainer in terms what is actually needed and how it will be used).

Seems that we kinda require "development" (e.g. for benchmarking, perhaps for omni-node - not sure what is the status there?).

And "local_testnet" is just for "our" runtimes? Not really required anywhere in generic tools?

I see those constants as a unified good common "examples". It is hard to say which is mandatory or optional here.
I mean, the module sp-genesis-builder does not even know that some frame-omni-bencher exists and uses those constants.

substrate/primitives/genesis-builder/src/lib.rs

…testnets

bkontur added T12-benchmarks This PR/Issue is related to benchmarking and weights. T14-system_parachains This PR/Issue is related to system parachains. R0-silent Changes should not be mentioned in any release notes labels Aug 12, 2024

bkontur force-pushed the bko-get_preset-for-testnets branch from 63d05be to 932e369 Compare August 13, 2024 08:54

This was referenced Aug 13, 2024

CI short benchmarking with frame-omni-bencher #4405

Closed

frame-omni-bencher fix for --repeat > 1 #5083

Draft

bkontur force-pushed the bko-get_preset-for-testnets branch from 932e369 to 80475ff Compare August 30, 2024 13:56

michalkucharczyk reviewed Aug 30, 2024

View reviewed changes

bkontur mentioned this pull request Aug 30, 2024

asset-hub-rococo: genesis config presets added #3996

Merged

bkontur force-pushed the bko-get_preset-for-testnets branch 2 times, most recently from 89133a0 to 493ad6b Compare September 1, 2024 21:00

bkontur force-pushed the bko-get_preset-for-testnets branch from 493ad6b to 4ae31df Compare September 2, 2024 11:09

michalkucharczyk reviewed Sep 2, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs Outdated Show resolved Hide resolved

bkontur force-pushed the bko-get_preset-for-testnets branch from e96f540 to 24d28ae Compare September 2, 2024 19:36

bkontur mentioned this pull request Sep 3, 2024

polkadot-omni-node: Fully remove benchmark sub-command #5564

Open

bkontur force-pushed the bko-get_preset-for-testnets branch 2 times, most recently from bc435cd to 8238baf Compare September 9, 2024 17:58

bkontur mentioned this pull request Sep 9, 2024

[benchmarking] Reset to genesis storage after each run #5655

Open

bkontur force-pushed the bko-get_preset-for-testnets branch 2 times, most recently from b95e603 to c35a621 Compare September 11, 2024 09:26

paritytech-review-bot bot requested a review from a team September 13, 2024 11:23

Some fixes around get_account_id_from_seed

ea855a1

bkontur requested a review from a team as a code owner September 13, 2024 11:31

Revert and re-export

42fce72

bkontur requested a review from michalkucharczyk September 13, 2024 11:43

mordamax approved these changes Sep 13, 2024

View reviewed changes

bkontur mentioned this pull request Sep 13, 2024

Enable GHA short benchmarks with frame-omni-bencher #5706

Open

bkontur added 2 commits September 13, 2024 14:37

Merge remote-tracking branch 'origin/master' into bko-get_preset-for-…

4424567

…testnets

prdoc

aa9bfcc

kianenigma reviewed Sep 13, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-westend/src/genesis_config_presets.rs Show resolved Hide resolved

kianenigma reviewed Sep 13, 2024

View reviewed changes

polkadot/runtime/rococo/src/genesis_config_presets.rs Outdated Show resolved Hide resolved

bkontur mentioned this pull request Sep 13, 2024

Refactor get_account_id_from_seed / get_from_seed to one common place #5705

Open

Merge branch 'master' into bko-get_preset-for-testnets

8f33808

franciscoaguirre approved these changes Sep 16, 2024

View reviewed changes

michalkucharczyk approved these changes Sep 16, 2024

View reviewed changes

michalkucharczyk reviewed Sep 16, 2024

View reviewed changes

prdoc/pr_5327.prdoc Outdated Show resolved Hide resolved

bkontur added 2 commits September 18, 2024 00:17

Merge remote-tracking branch 'origin/master' into bko-get_preset-for-…

e28bf03

…testnets

Merge remote-tracking branch 'origin/master' into bko-get_preset-for-…

faab276

…testnets

bkontur changed the title ~~Add get_preset to the testnet runtimes~~ Moved presets to the testnet runtimes Sep 18, 2024

bkontur added 2 commits September 18, 2024 09:15

prdoc

e8f3bbb

Refactor presets for LOCAL_TESTNET_RUNTIME_PRESET

beded8e

bkontur requested a review from kianenigma September 18, 2024 08:19

michalkucharczyk reviewed Sep 18, 2024

View reviewed changes

bkontur commented Sep 18, 2024

View reviewed changes

substrate/primitives/genesis-builder/src/lib.rs Outdated Show resolved Hide resolved

bkontur added 3 commits September 18, 2024 11:06

Update substrate/primitives/genesis-builder/src/lib.rs

b60c89a

prdoc

5308200

Merge remote-tracking branch 'origin/master' into bko-get_preset-for-…

992af98

…testnets

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moved presets to the testnet runtimes #5327

Moved presets to the testnet runtimes #5327

bkontur commented Aug 12, 2024 •

edited

Loading

bkontur commented Aug 30, 2024 •

edited

Loading

michalkucharczyk commented Aug 30, 2024

michalkucharczyk Aug 30, 2024 •

edited

Loading

bkontur Aug 30, 2024

bkontur commented Aug 30, 2024

michalkucharczyk commented Aug 30, 2024

michalkucharczyk commented Aug 30, 2024

paritytech-cicd-pr commented Sep 1, 2024

paritytech-cicd-pr commented Sep 1, 2024

bkontur commented Sep 2, 2024

command-bot bot commented Sep 2, 2024 •

edited

Loading

command-bot bot commented Sep 2, 2024

bkontur commented Sep 13, 2024

mordamax left a comment

bkontur commented Sep 13, 2024

michalkucharczyk commented Sep 13, 2024

michalkucharczyk left a comment •

edited

Loading

michalkucharczyk Sep 18, 2024 •

edited

Loading

bkontur Sep 18, 2024

Moved presets to the testnet runtimes #5327

Are you sure you want to change the base?

Moved presets to the testnet runtimes #5327

Conversation

bkontur commented Aug 12, 2024 • edited Loading

Follow-ups

bkontur commented Aug 30, 2024 • edited Loading

michalkucharczyk commented Aug 30, 2024

michalkucharczyk Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

bkontur Aug 30, 2024

Choose a reason for hiding this comment

bkontur commented Aug 30, 2024

michalkucharczyk commented Aug 30, 2024

michalkucharczyk commented Aug 30, 2024

paritytech-cicd-pr commented Sep 1, 2024

paritytech-cicd-pr commented Sep 1, 2024

bkontur commented Sep 2, 2024

command-bot bot commented Sep 2, 2024 • edited Loading

command-bot bot commented Sep 2, 2024

bkontur commented Sep 13, 2024

mordamax left a comment

Choose a reason for hiding this comment

bkontur commented Sep 13, 2024

michalkucharczyk commented Sep 13, 2024

michalkucharczyk left a comment • edited Loading

Choose a reason for hiding this comment

michalkucharczyk Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

bkontur Sep 18, 2024

Choose a reason for hiding this comment

bkontur commented Aug 12, 2024 •

edited

Loading

bkontur commented Aug 30, 2024 •

edited

Loading

michalkucharczyk Aug 30, 2024 •

edited

Loading

command-bot bot commented Sep 2, 2024 •

edited

Loading

michalkucharczyk left a comment •

edited

Loading

michalkucharczyk Sep 18, 2024 •

edited

Loading