Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests with 1.58.1 and stable, and publish a MSRV. #116

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

egrimley-arm
Copy link
Collaborator

@egrimley-arm egrimley-arm commented Aug 16, 2023

(Perhaps it should have been an MSRV?)

@egrimley-arm
Copy link
Collaborator Author

egrimley-arm commented Aug 21, 2023

Currently one sees: "All tests Expected — Waiting for status to be reported" because (I think) GitHub is waiting for the test called "All tests" to finish. But there no longer is a test with that name because this PR renames that test! It seems like a bug in the design of GitHub CI, and it seems to be discussed here: https://github.com/orgs/community/discussions/26733

Any ideas for what should be done?

@ionut-arm
Copy link
Member

I'll merge it manually if you're okay with that

@egrimley-arm
Copy link
Collaborator Author

Any ideas for what should be done?

If there isn't a neater solution, perhaps someone who is an "Owner" of this repo should change the settings (Settings -> Branches -> Branch protection rule -> Edit, or Settings -> Rules -> Rulesets -> ..., depending on how it's been set up) just before this is merged.

@egrimley-arm
Copy link
Collaborator Author

I'll merge it manually if you're okay with that

OK. And then change the rules afterwards, presumably. (Or one could delete the names of the tests from the settings, lose the automation and assume that a PR won't get two approvals if it's failing its tests.)

@ionut-arm ionut-arm merged commit 62eb63a into parallaxsecond:main Aug 22, 2023
@egrimley-arm egrimley-arm deleted the pr-ci-versions branch August 22, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants