-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix pr check issues #780
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: reubenmiller <[email protected]>
29808bf
to
b2d732a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your fixes here and in other repos!
67bb731
to
d31f237
Compare
@hug-dev I've extended the scope of this PR to also include some of the additional changes to allow the PR checks to be able to pass. There were multiple issues which were blocking this (cargo-deny config, out of date libraries which caused cargo-deny to fail, clippy errors). Once this is merged, then the PRs should be a lot slimmer. |
Ok, I was too optimistic. Seems there are some changes due to the spiffe upgrade. I'll have to spend some time getting a use-able dev setup so I can test this locally before pushing a fix. |
Signed-off-by: reubenmiller <[email protected]>
d31f237
to
fbbb1ff
Compare
After looking into spiffe a bit deeper and reading the CHANGELOG.md it seems that it is not going to be a simple upgrade as the from 0.3.x it requires tokio and some other breaking changes. Instead I've added the spiffe errors to the cargo-deny config to ignore them for now until a decision can be made on how to move forward. |
Fix various issues with current Rust pipeline. The different changes are still split in different commits, however all of the commits related to making the PR checks pass again (which should make it also easier to merge the PR without having to bypass any checks).
Fix clippy error on Rust stable.
Update spiffe dependencyThe spiffe dependency was outdated and causing an error in the cargo-deny.cargo-deny
cargo-deny has gone through some changes and many of the properties have been deprecated. Comments were removed from the deny.toml as the comments were introducing too much noise which made the file harder to read (imho). Two new advisories were added to the ignore list (with reasons) as one was due to the old clap version (due to current MSRV), and one due to using the unmaintained derivation crate. The latter will require a decision before a replacement can be applied to all related parsec projects.