ci: exit early if any of the Hive images fail to save #15273
Merged
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
the
A-ci
Rjected
approved these changes
Mar 25, 2025
| docker save hive/simulators/smoke/network:latest -o ../hive_assets/smoke_network.tar & saving_pids+=( $! ) | ||
| docker save hive/simulators/ethereum/sync:latest -o ../hive_assets/ethereum_sync.tar & saving_pids+=( $! ) | ||
| for pid in "${saving_pids[@]}"; do | ||
| wait "$pid" || exit |
There was a problem hiding this comment.
will we get any error message here / will it be clear what happened if we fail here
There was a problem hiding this comment.
good point, would be good to add a message here
There was a problem hiding this comment.
yes, we will get an error from docker save and also exit with a non-zero error code
jenpaff
approved these changes
Mar 25, 2025
jenpaff
reviewed
Mar 25, 2025
| @@ -20,18 +20,20 @@ echo "Building images" | |||
| ./hive -client reth --sim "ethereum/sync" -sim.timelimit 1s || true & | |||
| wait | |||
|
|
|||
| # Run docker save in parallel and wait | |||
| echo "Saving images" | |||
There was a problem hiding this comment.
possibly would leave this log for vis
fgimenez
approved these changes
Mar 25, 2025
jenpaff
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.