Push nightly image with profiling profile #15206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
reviewed
Mar 21, 2025
laibe
approved these changes
Mar 21, 2025
sure, can add |
Rjected
reviewed
Mar 21, 2025
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Dan Cline <[email protected]>
Rjected
reviewed
Mar 21, 2025
Co-authored-by: Dan Cline <[email protected]>
loocapro
pushed a commit
to loocapro/reth
that referenced
this pull request
Mar 23, 2025
Co-authored-by: Dan Cline <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For running automated benchmarking we will need a docker image built with profiling profile. This PR adds this to our nightly build workflow.
Note: Thought about whether to make the profiling profile default in nightly tag, but decided against it since some teams use the
nightlytag (built withmaxperf) and just pushing a separate image with new tag callednightly-profiling.