CI Use released numpy for Windows wheels testing #61248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lesteve
changed the title
|
I guess this doesn't fix the nightly wheels failure, since the issue seems related to cython dev according to #61249. It could still be worth to merge this PR to use released numpy. I'll move it ouf of draft, when the wheels are back to green on |
lesteve
changed the title
…e-fix-windows-free-threaded
lesteve
changed the title
|
OK I guess this is ready to be reviewed, this simplifies the Windows free-threaded further (on top of #61249) by using released numpy for testing. cc @mroeschke. The Wheels testing seems to be fine, see build log. Not quite sure why the mypy error is about since it does not seem related to my PR, see build log. |
mroeschke
approved these changes
Apr 10, 2025
|
Thanks @lesteve (and for your initial stab at debugging our wheel failures) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #61249 this also used released numpy for testing on Windows free-threaded wheels.