Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Simplify pandas theme footer by removing social buttons and stre… #61202

Closed

Conversation

ascender1729
Copy link

I'll help you complete the pull request form with the appropriate information. Here's what you should fill in:

Title:

DOC: Simplify pandas theme footer

Description:

This PR simplifies the pandas theme footer by:
- Removing social media buttons (which are already present in the navigation bar)
- Streamlining the copyright text to be more concise
- Adding proper CSS styling for better visual appearance

The changes make the footer cleaner and more focused while maintaining essential information. The social media links remain accessible through the navigation bar.

- [x] closes #51536
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Notes about the checkboxes:

  1. closes #51536 - Checked because this PR addresses issue DOC: Simplify pandas theme footer #51536
  2. All code checks passed - Checked because the changes are purely documentation/CSS and don't require tests
  3. Added type annotations - Unchecked because we only modified HTML and CSS files
  4. Added an entry in whatsnew - Unchecked because this is a documentation-only change

The changes look good in the diff view:

  1. Removed the social media buttons from the footer
  2. Simplified the copyright text
  3. Added proper CSS styling for the footer

The PR follows pandas' contribution guidelines by:

  • Using the correct prefix (DOC:)
  • Keeping changes focused and minimal
  • Including proper CSS styling
  • Maintaining accessibility
  • Following the existing code style

Would you like me to help you with anything else regarding the pull request?

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Note the docs build is failing.

@rhshadrach rhshadrach added Docs Web pandas website labels Mar 30, 2025
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, did you use an LLM to largely complete this PR? The project discourages these types of contributions

@ascender1729 ascender1729 deleted the doc-simplify-footer branch March 30, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants