ENH: Follow up to PR #59577, Series.str.get_dummies() raise on str type #59786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaronchucarroll
commented
Sep 12, 2024
aaronchucarroll
commented
- [Tests added and passed]
- All [code checks passed]
…hucarroll/pandas into stringmethods-get-dummies
…hucarroll/pandas into stringmethods-get-dummies
|
@rhshadrach Please see latest changes |
|
@aaronchucarroll - I believe there is an issue related to this, is that right? |
|
I don't think there exists an issue for this. These are the requested follow-up changes to my last PR (#59577) |
rhshadrach
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks for the followup!
@mroeschke - I've resolved your comments from #59577 where they have been taken care of. There are a few comments that could use your review.
…hucarroll/pandas into stringmethods-get-dummies
|
@rhshadrach Please see new changes |
rhshadrach
requested changes
Oct 12, 2024
| @@ -54,9 +54,8 @@ Other enhancements | |||
| - :meth:`Series.cummin` and :meth:`Series.cummax` now supports :class:`CategoricalDtype` (:issue:`52335`) | |||
| - :meth:`Series.plot` now correctly handle the ``ylabel`` parameter for pie charts, allowing for explicit control over the y-axis label (:issue:`58239`) | |||
| - :meth:`DataFrame.plot.scatter` argument ``c`` now accepts a column of strings, where rows with the same string are colored identically (:issue:`16827` and :issue:`16485`) | |||
| - :meth:`Series.map` can now accept kwargs to pass on to func (:issue:`59814`) | |||
There was a problem hiding this comment.
Can you restore this note. The new note being added looks good.
| @@ -2482,12 +2482,16 @@ def get_dummies( | |||
| 1 False False False | |||
| 2 True False True | |||
| """ | |||
| from pandas.core.dtypes.common import is_string_dtype | |||
There was a problem hiding this comment.
pandas.core.dtypes.common is already being imported from at the top of this file. Can you move this import up there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.