-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add pre-commit check for setup.cfg options.extras_require #49261
Merged
Merged
Changes from 12 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
542b336
Add dependency check for setup.cfg
kostyafarber f9592e5
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 6abda3e
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 39e86cc
improve diff alert, add install mapping, remove test deps
kostyafarber 7edca5c
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 97adc2a
align versions across min version files
kostyafarber 08a3e3f
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 4036bfe
fix version issues for boto3, s3fs and pyqt5. Small change to script
kostyafarber 953e885
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 8aed966
Merge branch 'main' into issue-48949
kostyafarber d079b4f
fix version equality, modify script for CI check
kostyafarber 2d272c9
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber 4f95fb2
Merge branch 'pandas-dev:main' into issue-48949
kostyafarber a256dcc
fix version typo in min version yaml and update min version script
kostyafarber 52efecb
bump fsspec, gcsfs to match in whats new
kostyafarber 309dc97
Merge branch 'main' into issue-48949
kostyafarber af47477
Revert "bump fsspec, gcsfs to match in whats new"
kostyafarber 6f6b97d
align fastparquet, lowercase PyQt5
kostyafarber 637dc10
Merge branch 'main' into issue-48949
kostyafarber 674dadd
Merge branch 'main' into issue-48949
kostyafarber 3c4a28e
Merge branch 'main' into issue-48949
kostyafarber 0366b53
ENH: align matplotlib versions
kostyafarber 56c7c05
Merge branch 'main' into issue-48949
kostyafarber e970faa
Merge branch 'main' into issue-48949
kostyafarber 943d5db
Merge branch 'main' into issue-48949
kostyafarber bace671
ENH: align matplotlib in setup.cfg
kostyafarber 9f414d8
Merge branch 'main' into issue-48949
kostyafarber e92334d
Merge branch 'main' into issue-48949
kostyafarber aee587a
bump s3fs across min version files
kostyafarber e5ea765
Merge branch 'main' into issue-48949
kostyafarber d2608b1
Update scripts/validate_min_versions_in_sync.py
kostyafarber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency was bumped in 1.5 to a newer version: https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.5.0.html#backwards-incompatible-api-changes
So we shouldn't be testing an older version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing build issues that's why I pinned it at 0.4.0 #49261 (comment).
What is the verdict on what version we want to put in here for
s3fs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JMBurley cc for visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kostyafarber . I'm not sure if pandas can be built successfully with s3fs>=0.4.0 (and other packages active that require
boto3
), and I know that pandas cannot be packaged into larger production environments when it enforcess3fs>=0.4.0
because professional codebases need otherboto3
imports.However, I'm not a pandas maintainer so I don't get to make an assertion on what to pin s3fs to. @mroeschke controls the initial take on this. I'd make the pitch for not advancing the s3fs version pin, because I do not know of any benefits we need (could be a lack of awareness on my part) and I do know of major python ecosystem headaches from advancing the pin.
My team pins
s3fs<=0.4.0
versions internally for this exact reason. Ditto my colleagues controlling data science at other companies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JMBurley - could you please clarify about
? The
environment.yml
file has a later version ofs3fs
, and building pandas with theenvironment.yml
file works finepandas/environment.yml
Line 48 in 0b93117