fix: Position manager search and url generation not working #9219

memoyil · 2024-03-06T15:16:50Z

PR-Codex overview

The focus of this PR is to enhance filtering and searching functionalities in the PositionManagers feature.

Detailed summary

Improved filtering logic for URL query parameters
Implemented advanced search functionality using regular expressions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-03-06T15:16:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2024 8:14am

6 Skipped Deployments

Name	Status	Preview	Updated (UTC)
aptos-web	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am
blog	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am
bridge	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am
games	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am
gamification	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am
uikit	⬜️ Ignored (Inspect)	Visit Preview	Jul 22, 2024 8:14am

changeset-bot · 2024-03-06T15:16:55Z

⚠️ No Changeset found

Latest commit: 9d1beb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-03-06T15:21:44Z

Typescript errors check

862 ts errors detected in all the codebase 😟.

Well done: no ts errors in files changed in this PR! 🎉

_{chefjackson/action-check-typescript}

chefjackson · 2024-03-07T02:34:57Z

apps/web/src/views/PositionManagers/hooks/useFilters.ts

+            router.asPath,
+            value
+              ? {
+                  [filterName]: encodeURIComponent(value.trim()),


updateQuery will do the encode so no need to encode again

Currently it is not encoding

Just tried on prod seems ok?

chefjackson · 2024-03-07T02:35:23Z

apps/web/src/views/PositionManagers/hooks/useFilters.ts

@@ -7,18 +7,26 @@ function filterHookFactory(filterName: string) {
    const router = useRouter()
    const filter = useMemo(() => {
      const value = router.query[filterName]
-      if (Array.isArray(value)) {
-        return value[0]
+      if (value) {


It will break if I empty the search field?

it will not break, value will be undefined therefore it will return all positions

but if the value changed from a valid string to an empty string, the query won't get updated?

was trying to delete the search and it's not working

memoyil · 2024-03-08T11:31:24Z

@chefjackson You can review it again

chefjackson · 2024-03-11T09:11:17Z

apps/web/src/views/PositionManagers/containers/VaultCards.tsx

+const createSearchRegex = (wordText) => {
+  const words = wordText.split(/\s+/)
+  const escapedWords = words.map((word) => word.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
+  const pattern = escapedWords.map((word) => `(?=.*\\b${word}\\b)`).join('')


Can we support partial search? For example I'd prefer to be able to search bnb instead of typing wbnb

chefjackson · 2024-03-13T04:56:17Z

apps/web/src/views/PositionManagers/hooks/useFilters.ts

+          return decodeURIComponent(value[0])
+        }
+        return decodeURIComponent(value)
      }
-      return value
+      return undefined
    }, [router.query])

    const setFilter = useCallback(
      (value?: string) => {
+        const trimmedValue = value?.trim()
        router.push(
          updateQuery(router.asPath, {
-            [filterName]: value,
+            [filterName]: trimmedValue && encodeURIComponent(trimmedValue),


I don't think we need to encode and decode again? updateQuery is using url-parse to parse and serialize the url, which uses querystringify to encode and decode the querystring

https://github.com/pancakeswap/pancake-frontend/blob/develop/packages/utils/clientRouter.ts#L1-L17

May I ask what's the bad case here?

memoyil requested review from 0xjojoex, ChefMomota, Chef-Yogi, chefjackson, ChefJerry and ChefBingbong as code owners March 6, 2024 15:16

pull-request-size bot added the size/S label Mar 6, 2024

vercel bot had a problem deploying to Preview – web March 6, 2024 15:17 Failure

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from e3944ee to 9845968 Compare March 6, 2024 15:25

pull-request-size bot added size/M and removed size/S labels Mar 6, 2024

vercel bot deployed to Preview – web March 6, 2024 15:30 View deployment

chefjackson reviewed Mar 7, 2024

View reviewed changes

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 9845968 to 76efb37 Compare March 7, 2024 09:30

memoyil requested a review from chefjackson March 7, 2024 09:34

vercel bot deployed to Preview – web March 7, 2024 09:39 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 76efb37 to 94206ad Compare March 8, 2024 11:11

vercel bot deployed to Preview – web March 8, 2024 11:17 View deployment

pull-request-size bot added size/S and removed size/M labels Mar 8, 2024

vercel bot deployed to Preview – web March 8, 2024 11:36 View deployment

chefjackson reviewed Mar 11, 2024

View reviewed changes

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 7fbacce to 5441342 Compare March 11, 2024 10:36

vercel bot deployed to Preview – web March 11, 2024 10:43 View deployment

memoyil requested a review from chefjackson March 11, 2024 10:56

vercel bot deployed to Preview – web March 11, 2024 11:01 View deployment

chefjackson reviewed Mar 13, 2024

View reviewed changes

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 178f136 to 7c7ef18 Compare March 21, 2024 20:50

vercel bot deployed to Preview – web March 21, 2024 20:58 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 7c7ef18 to b7bfe59 Compare March 26, 2024 14:59

vercel bot deployed to Preview – web March 26, 2024 15:08 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from b7bfe59 to 1f3859a Compare March 27, 2024 18:05

vercel bot deployed to Preview – web March 27, 2024 18:15 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 1f3859a to cc209e7 Compare April 5, 2024 12:39

vercel bot deployed to Preview – web April 5, 2024 12:50 View deployment

vercel bot deployed to Preview – web April 5, 2024 13:06 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from be23492 to 48b672a Compare April 25, 2024 07:36

vercel bot deployed to Preview – web April 25, 2024 07:55 View deployment

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 48b672a to 0425128 Compare June 4, 2024 06:50

vercel bot deployed to Preview – gamification June 4, 2024 07:01 View deployment

vercel bot deployed to Preview – web June 4, 2024 07:04 View deployment

memoyil added 3 commits July 22, 2024 09:23

fix: Position manager search and url generation not working

c91ab96

fix: Cant be removed

17bf966

fix: Search text in vault content

9d1beb9

memoyil force-pushed the feature/fix_position_manager_search_not_working branch from 0425128 to 9d1beb9 Compare July 22, 2024 07:23

memoyil requested review from thechefpenguin and chef-eric as code owners July 22, 2024 07:23

vercel bot deployed to Preview – web July 22, 2024 08:14 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Position manager search and url generation not working #9219

fix: Position manager search and url generation not working #9219

memoyil commented Mar 6, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

changeset-bot bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

chefjackson Mar 7, 2024

memoyil Mar 7, 2024

chefjackson Mar 13, 2024

chefjackson Mar 7, 2024

memoyil Mar 7, 2024

chefjackson Mar 8, 2024

chefjackson Mar 8, 2024

memoyil Mar 8, 2024

memoyil commented Mar 8, 2024

chefjackson Mar 11, 2024

memoyil Mar 11, 2024

chefjackson Mar 13, 2024

chefjackson Mar 13, 2024

fix: Position manager search and url generation not working #9219

Are you sure you want to change the base?

fix: Position manager search and url generation not working #9219

Conversation

memoyil commented Mar 6, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

vercel bot commented Mar 6, 2024 • edited Loading

changeset-bot bot commented Mar 6, 2024 • edited Loading

⚠️ No Changeset found

github-actions bot commented Mar 6, 2024 • edited Loading

Typescript errors check

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

memoyil commented Mar 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

memoyil commented Mar 6, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

changeset-bot bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading