Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reset button for settings and use settings modalv2 for all swap & liquidity #11291

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Mar 5, 2025

Remove liquidity currently using old settings which includes obsolote fast routing setting

To reproduce

Go to remove lp (v2 / stable)
Click slippage tolerance
See old settings modal


PR-Codex overview

This PR focuses on enhancing the user experience by updating various components and hooks related to settings, modals, and user preferences, particularly around slippage, notifications, and token risk. It transitions to a new modal system and optimizes user preference handling.

Detailed summary

  • Updated SettingsModal to use SettingsModalV2 with improved state management.
  • Introduced ModalV2 for better modal handling across components.
  • Enhanced user hooks to return default values for slippage, audio play, and other settings.
  • Removed unnecessary mode parameters from several components.
  • Added new features like token risk scanning and improved notification settings.
  • Simplified the useAllowNotifications hook to return default values.
  • Refactored various components to streamline settings management and user interactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 0:20am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Skipped (Inspect) Mar 20, 2025 0:20am

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 0312002

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – ton March 5, 2025 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview – ton March 5, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – ton March 5, 2025 09:56 Inactive
@memoyil memoyil force-pushed the feature/feat_use_settings_modal_2_for_swap_liquidity branch from f210791 to 1679ff0 Compare March 5, 2025 10:13
@vercel vercel bot temporarily deployed to Preview – ton March 5, 2025 10:13 Inactive
@memoyil memoyil changed the title feat: Use settings modalv2 for swap liquidity feat: Use settings modalv2 for all swap & liquidity Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant