Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resurrection by hanging ref and deletion by invalidated ancestry #541

Open
wants to merge 9 commits into
base: palantir-cassandra-2.2.18
Choose a base branch
from
Open

Fix resurrection by hanging ref and deletion by invalidated ancestry #541

wants to merge 9 commits into from

Conversation

wi11dey
Copy link
Contributor

@wi11dey wi11dey commented Sep 4, 2024 •
edited
Loading

This PR

  • Does not trust the ancestors of any stats file written before this version
    • A VALID_ANCESTORS component is added as a flag from this version onward
    • For older stats files, treated as no ancestors
  • Skips SSTable renumbering when assumeCfIsEmpty
  • When SSTables need to be renumbered, the stats file gets deleted
  • Adds palantir_cassandra.dry_run_ancestor_deletion system parameter to only dry-run deleting leftover compaction ancestors.

@wi11dey wi11dey force-pushed the wdey/neither-resurrection-nor-loss branch 2 times, most recently from 689eb95 to 302e8d5 Compare September 4, 2024 23:43
@wi11dey wi11dey force-pushed the wdey/neither-resurrection-nor-loss branch 2 times, most recently from 49cabf1 to f3ac913 Compare September 5, 2024 05:10
@wi11dey wi11dey force-pushed the wdey/neither-resurrection-nor-loss branch from f3ac913 to 1acaef6 Compare September 5, 2024 05:14
@wi11dey wi11dey force-pushed the wdey/neither-resurrection-nor-loss branch from 65fd950 to ecd3cd1 Compare September 5, 2024 05:56
@wi11dey wi11dey force-pushed the wdey/neither-resurrection-nor-loss branch from ecd3cd1 to 89d6b16 Compare September 5, 2024 05:59
d-guo
d-guo approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@d-guo d-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-guo d-guo d-guo approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wi11dey @d-guo @lyubent @svc-autorelease