Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time_window on ingestion alerts #171

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

acuiuli
Copy link
Contributor

@acuiuli acuiuli commented Mar 6, 2025

Changed the ingestion alerts time windows to match the frequency in order to avoid multiple alerts for a single error

@acuiuli acuiuli requested review from a team as code owners March 6, 2025 16:30
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: d13acdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@acuiuli acuiuli temporarily deployed to infra-prod-ci March 6, 2025 16:32 — with GitHub Actions Inactive
@lucacavallaro lucacavallaro changed the title Fix ingestion alerts to avoid duplicates Update time_window on ingestion alerts Mar 6, 2025
@acuiuli acuiuli temporarily deployed to infra-prod-ci March 7, 2025 08:32 — with GitHub Actions Inactive
@acuiuli acuiuli requested a review from lucacavallaro March 7, 2025 08:32
Copy link
Contributor

github-actions bot commented Mar 7, 2025

📖 Terraform Plan ('infra/resources/prod') - success

Terraform Plan
module.web_apps.module.citizen_func_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
module.web_apps.module.etl_func_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.monitoring.azurerm_monitor_scheduled_query_rules_alert.message-ingestion-alert will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "message-ingestion-alert" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Insights/scheduledQueryRules/[io-p-itn-com] Message Ingestion Error"
        name                    = "[io-p-itn-com] Message Ingestion Error"
        tags                    = {}
      ~ time_window             = 30 -> 10
        # (12 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.monitoring.azurerm_monitor_scheduled_query_rules_alert.message-ingestion-count-collect-alert will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "message-ingestion-count-collect-alert" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Insights/scheduledQueryRules/[io-p-itn-com] Message Ingestion Count Collection Error"
        name                    = "[io-p-itn-com] Message Ingestion Count Collection Error"
        tags                    = {}
      ~ time_window             = 30 -> 10
        # (12 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.monitoring.azurerm_monitor_scheduled_query_rules_alert.message-status-ingestion-alert will be updated in-place
  ~ resource "azurerm_monitor_scheduled_query_rules_alert" "message-status-ingestion-alert" {
        id                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Insights/scheduledQueryRules/[io-p-itn-com] Message Status Ingestion Error"
        name                    = "[io-p-itn-com] Message Status Ingestion Error"
        tags                    = {}
      ~ time_window             = 30 -> 10
        # (12 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.storage_api_weu.azurerm_storage_container.message_content,
  on ../_modules/storage_accounts/storage_account_api.tf line 32, in resource "azurerm_storage_container" "message_content":
  32:   storage_account_name  = module.storage_api.name

the `storage_account_name` property has been deprecated in favour of
`storage_account_id` and will be removed in version 5.0 of the Provider.

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

@acuiuli acuiuli added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit ac51570 Mar 7, 2025
5 checks passed
@acuiuli acuiuli deleted the fix-ingestion-alerts branch March 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants