Disable async deployment in function_app_deploy
#322
Merged
+37
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the `azure/webapps-deploy` action uses the async deploy mode that ends the workflow step once the artifact is pushed onto the function app, without waiting for its restart or any successful health probe. This behavior makes the `Ping Staging Health` step unreliable, as it is being executed before the actual deployment is finished, nullifying its purpose and causing unwanted swaps. Note that, in order to work, the target function app must declare the following environment variables: * `WEBSITE_SWAP_WARMUP_PING_PATH` - a public route that the swapping process use to make sure that the source slot is healthy * `WEBSITE_SWAP_WARMUP_PING_STATUSES` - the successful status code returned by the previous mapped route (es. 200) See the Azure documentation for more info https://learn.microsoft.com/en-us/azure/app-service/deploy-staging-slots?tabs=portal
|
gunzip
approved these changes
Feb 26, 2025
|
can we make the workflow fail fast if WEBSITE_SWAP_WARMUP_PING_PATH and WEBSITE_SWAP_WARMUP_PING_STATUSES are not set? maybe we can get them using cli |
Krusty93
reviewed
Feb 28, 2025
|
I like the changes, but how we make sure the two environment variables are set? We should add them in DX module as well EDIT: I've seen now #323. Remember to notify developers that they need the latest TF module version if they want to use this workflow template |
gunzip
requested changes
Feb 28, 2025
Explain the issues faced when instrumenting an `ESM` application using OpenTelemetry Fixes #CES-783 --------- Co-authored-by: Danilo Spinelli <[email protected]> Co-authored-by: Danilo Spinelli <[email protected]>
Enhance the documentation for AI to ensure better understanding and uniformity across the content. Closes CES-733
Set `var.health_check_path` as custom warm-up path to constraint the swap operation only when the source slots is healthy.
Co-authored-by: Danilo Spinelli <[email protected]>
On March 31, 2025, support for instrumentation key ingestion will end Resolves #CES-723
Add support for semver version ranges (e.g. ~2.4) in turbo version detection
When tier is set to `s`, but AI is enabled, the plan fails because it assumes the APIM logger exists. With this change, when AI is enabled, then the module creates an APIM logger as well Closes #273 #CES-799 --------- Co-authored-by: Mario Mupo <[email protected]>
#252) This pull request aims to **align the sample rate settings for both the Host and Worker** in the Azure Functions module's AI tracing. The changes ensure consistency and potentially improve the reliability of Application Insights sampling. --------- Co-authored-by: Danilo Spinelli <[email protected]> Co-authored-by: Danilo Spinelli <[email protected]>
) Add documentation to guide developers in managing IAM setup among resources of different Azure subscriptions Closes #CES-825 --------- Co-authored-by: Danilo Spinelli <[email protected]>
<!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> <!--- Even if we are all from our internal team, we may not be on the same page. --> <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> <!--- This will improve our projects in the long run! Thanks. --> ### List of changes <!--- Describe your changes in detail --> Add documentation to explain how and why IAM DX framework was designed ### Motivation and context <!--- Why is this change required? What problem does it solve? --> Making everyone understands how the framework was designed and how to exploit it ### Type of changes - [ ] Add new resources - [X] Update configuration to existing resources - [ ] Remove existing resources ### Does this introduce a change to production resources with possible user impact? - [ ] Yes, users may be impacted applying this change - [X] No ### Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Mario Mupo <[email protected]> Co-authored-by: Danilo Spinelli <[email protected]>
…340) Update the Azure IAM documentation to enhance clarity.
The `connection_string` for the `azurerm_api_management_logger` resource has been introduced in version `4.1.0` of the provider Fixes #CES-809
Corrected typographical errors and updated module versioning in the Azure IAM documentation for clarity and accuracy.
) <!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> <!--- Even if we are all from our internal team, we may not be on the same page. --> <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> <!--- This will improve our projects in the long run! Thanks. --> ### List of changes <!--- Describe your changes in detail --> Added new modules for container app and container app environment. Minor change in core module with new Private DNS Zone for container app. ### Motivation and context <!--- Why is this change required? What problem does it solve? --> ### Type of changes - [x] Add new resources - [x] Update configuration to existing resources - [ ] Remove existing resources ### Does this introduce a change to production resources with possible user impact? - [ ] Yes, users may be impacted applying this change - [x] No ### Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Resolves: #CES-739 --------- Co-authored-by: Christian Calabrese <[email protected]>
Add documentation to workaround the issue of hidden AppSettings in AppService and FunctionApp Closes #CES-740
#342) Update sidebar labels throughout the documentation to enhance clarity and maintain consistency in terminology.
Fix broken link in "Ensuring Azure AppSettings Visibility in Terraform Plans" doc.
This helps the navigation on the Azure Portal, because it links the resource Closes #CES-839
Introduce guidelines for managing pull requests to promote clarity and consistency. Following these guidelines will help streamline the review process and improve communication within the team Closes #CES-758 --------- Co-authored-by: Danilo Spinelli <[email protected]>
gunzip
approved these changes
Mar 12, 2025
Krusty93
approved these changes
Mar 12, 2025
lucacavallaro
force-pushed
the
fixes/legacy-workflow-azcli
branch
from
f089759 to
e139e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
azure/webapps-deployaction uses the async deploy mode that ends the workflow step once the artifact is pushed onto the function app, without waiting for its restart or any successful health probe.This behavior makes the
Ping Staging Healthstep unreliable, as it is being executed before the actual deployment is finished, nullifying its purpose and causing unwanted swaps.Note that, in order to work, the target function app must declare the following environment variables:
WEBSITE_SWAP_WARMUP_PING_PATH- a public route that the swapping process use to make sure that the source slot is healthyWEBSITE_SWAP_WARMUP_PING_STATUSES- the successful status code returned by the previous mapped route (es. 200)See the Azure documentation for more info https://learn.microsoft.com/en-us/azure/app-service/deploy-staging-slots?tabs=portal