-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] New Splash Texts Feb. 2025 #5345
Draft
damocleas
wants to merge
15
commits into
beta
Choose a base branch
from
splashtexts
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will display a random Pokemon's name, followed by an exclamation point (ex. "Bulbasaur!").
It even says to do so whenever weight multipliers are adjusted...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Localization
Provides or updates translation efforts
Miscellaneous
Changes that don't fit under any other label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
More splash texts!
Why am I making these changes?
People love Splash Texts. Adding some more since it has been ~4+ months!
What are the changes from a developer perspective?
Screenshots/Videos
Video of the Pokemon name splash message in action
splash.text.mp4
How to test the changes?
idk, WIP list here
https://github.com/damocleas/pokerogue-locales/blob/main/en/splash-texts.json
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: