Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] New Splash Texts Feb. 2025 #5345

Draft
wants to merge 15 commits into
base: beta
Choose a base branch
from
Draft

[Misc] New Splash Texts Feb. 2025 #5345

wants to merge 15 commits into from

Conversation

damocleas
Copy link
Collaborator

@damocleas damocleas commented Feb 16, 2025

What are the changes the user will see?

More splash texts!

Why am I making these changes?

People love Splash Texts. Adding some more since it has been ~4+ months!

What are the changes from a developer perspective?

Screenshots/Videos

Video of the Pokemon name splash message in action
splash.text.mp4

How to test the changes?

idk, WIP list here
https://github.com/damocleas/pokerogue-locales/blob/main/en/splash-texts.json

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

damocleas and others added 2 commits February 16, 2025 00:28
This will display a random Pokemon's name, followed by an exclamation point (ex. "Bulbasaur!").
@Madmadness65 Madmadness65 added Localization Provides or updates translation efforts Miscellaneous Changes that don't fit under any other label labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants