feat: persistance system #61

saenai255 · 2022-09-01T16:59:38Z

Closes #28

codecov · 2022-09-01T17:02:44Z

Codecov Report

Merging #61 (8eb4a20) into oxidation (88764fe) will decrease coverage by 42.98%.
The diff coverage is 54.51%.

@@              Coverage Diff               @@
##           oxidation      #61       +/-   ##
==============================================
- Coverage     100.00%   57.01%   -42.99%     
==============================================
  Files              1        7        +6     
  Lines             22      328      +306     
==============================================
+ Hits              22      187      +165     
- Misses             0      141      +141

Impacted Files	Coverage Δ
src/config.rs	`100.00% <ø> (ø)`
src/model/pacbuild.rs	`4.44% <4.44%> (ø)`
src/store/filters.rs	`40.00% <40.00%> (ø)`
src/store/base.rs	`57.30% <57.30%> (ø)`
src/store/errors.rs	`75.00% <75.00%> (ø)`
src/store/query_builder.rs	`82.14% <82.14%> (ø)`
src/model/repository.rs	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

wizard-28

Well, that's my quick review, this PR will take a few more days to fully review.

General impressions:

Add more docs, the whole fs module's missing docs.
Look into error handling libraries
13 of the 16 tests fail, check the Code Coverage CI.

src/model/pacbuild.rs

src/model/mod.rs

src/store/base.rs

src/store/errors.rs

src/store/filters.rs

.gitignore

src/store/fs.rs

src/store/base.rs

Co-authored-by: Sourajyoti Basak <[email protected]>

…tall into feat/persistance-system

wizard-28

Add code examples to the public methods detailing how to use them.

Also, add a full-fledged example(s) on how to use the database module, in examples/ folder on the root of the project.

So people can run cargo run --example <database_example> to run the example.

src/store/base.rs

Co-authored-by: Sourajyoti Basak <[email protected]>

wizard-28

Can you rename the PacBuild fields to resemble their PACBUILD counterparts wherever possible? Example: package_names -> pkgname, homepage -> url, licenses -> license

wizard-28 · 2022-10-29T18:51:02Z

src/model/pacbuild.rs

+    /// Repology filter.
+    ///
+    /// # Example
+    /// **TBA**
+    pub repology: String,


Shouldn't this be a HashMap of the filters?

wizard-28 · 2022-10-29T18:51:51Z

src/model/pacbuild.rs

+    ///
+    /// # Example
+    /// `Paul Cosma <[email protected]>`
+    pub maintainers: Vec<String>,


Suggested change

pub maintainers: Vec<String>,

pub maintainers: Vec<String>,

Shoud be optional

wizard-28 · 2022-10-29T18:52:01Z

src/model/pacbuild.rs

+    pub description: String,
+
+    /// Official homepage [URL].
+    pub homepage: URL,


Shoud be optional

wizard-28 · 2022-10-29T18:52:07Z

src/model/pacbuild.rs

+    pub homepage: URL,
+
+    /// Latest version fetched from Repology.
+    pub repology_version: Version,


Why should we store the repology version?

wizard-28 · 2022-10-29T18:54:20Z

src/model/pacbuild.rs

+    /// An array of packages that must be installed for the software to build
+    /// and run.
+    pub dependencies: Vec<VersionConstrainedPackageId>,


Shoud be optional

wizard-28 · 2022-10-29T18:56:29Z

src/model/pacbuild.rs

+    /// The group the package belongs in. For instance, when installing
+    /// `plasma`, it installs all packages belonging in that group.
+    pub groups: Vec<GroupId>,


Shoud be optional

wizard-28 · 2022-10-29T18:56:37Z

src/model/pacbuild.rs

+    /// Optional dependencies. Each Key:Pair is meant to describe the package
+    /// identifier and the reason for installing.
+    pub optional_dependencies: HashMap<VersionConstrainedPackageId, String>,


Shoud be optional

wizard-28 · 2022-10-29T18:56:45Z

src/model/pacbuild.rs

+    /// An array of packages that are only required to build the software.
+    pub make_dependencies: Vec<VersionConstrainedPackageId>,


Shoud be optional

wizard-28 · 2022-10-29T18:59:42Z

src/model/pacbuild.rs

+    /// The license under which the software is distributed.
+    pub licenses: Vec<String>,


Should be optional

wizard-28 · 2022-10-29T19:00:42Z

src/model/pacbuild.rs

+    /// File required to build the package.
+    pub url: URL,


Do we need to store the url in the database?

saenai255 changed the base branch from develop to oxidation September 1, 2022 17:00

saenai255 self-assigned this Sep 1, 2022

saenai255 force-pushed the feat/persistance-system branch from b3086fc to 9a6a054 Compare September 1, 2022 17:24

wizard-28 linked an issue Sep 2, 2022 that may be closed by this pull request

Implement a flexible cache system #28

Open

wizard-28 added the enhancement New feature or request label Sep 5, 2022

saenai255 marked this pull request as ready for review September 5, 2022 16:48

saenai255 requested a review from wizard-28 September 5, 2022 16:49

wizard-28 suggested changes Sep 5, 2022

View reviewed changes

saenai255 force-pushed the feat/persistance-system branch from 4374d8d to 1074520 Compare September 5, 2022 19:14

saenai255 added 5 commits September 6, 2022 20:49

add: persistance system

d2c0e26

add: caching system

94b29dc

deps: remove time 0.1 dependency

945b3ea

docs: improve style

817e873

chore: impl From for filters

7668b2a

saenai255 force-pushed the feat/persistance-system branch from ecdd8e3 to 7668b2a Compare September 6, 2022 17:49

wizard-28 suggested changes Oct 4, 2022

View reviewed changes

saenai255 and others added 11 commits October 4, 2022 19:11

Update src/store/fs.rs

53ae5de

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

acd0afe

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

af11403

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

43ebc11

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

d825b99

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

47cba1d

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

6c690f4

Co-authored-by: Sourajyoti Basak <[email protected]>

Update src/store/fs.rs

d454cfb

Co-authored-by: Sourajyoti Basak <[email protected]>

ref(store): ref so Base trait is not used

0ef067f

Merge branch 'feat/persistance-system' of github.com:pacstall/libpacs…

09838a6

…tall into feat/persistance-system

add: integration

6cb663b

wizard-28 suggested changes Oct 10, 2022

View reviewed changes

chore: use ensure! and report!

7cf0b38

Co-authored-by: Sourajyoti Basak <[email protected]>

saenai255 added 2 commits October 13, 2022 00:18

add: store examples

6de8656

add: rest of PKGBUILD spec

8eb4a20

wizard-28 suggested changes Oct 29, 2022

View reviewed changes

Elsie19 changed the title ~~Feat/persistance system~~ feat: persistance system Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: persistance system #61

feat: persistance system #61

saenai255 commented Sep 1, 2022 •

edited by wizard-28

Loading

codecov bot commented Sep 1, 2022 •

edited

Loading

wizard-28 left a comment

wizard-28 left a comment

wizard-28 left a comment

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

wizard-28 Oct 29, 2022

		/// An array of packages that are only required to build the software.
		pub make_dependencies: Vec<VersionConstrainedPackageId>,

		/// The license under which the software is distributed.
		pub licenses: Vec<String>,

feat: persistance system #61

Are you sure you want to change the base?

feat: persistance system #61

Conversation

saenai255 commented Sep 1, 2022 • edited by wizard-28 Loading

codecov bot commented Sep 1, 2022 • edited Loading

Codecov Report

wizard-28 left a comment

Choose a reason for hiding this comment

wizard-28 left a comment

Choose a reason for hiding this comment

wizard-28 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saenai255 commented Sep 1, 2022 •

edited by wizard-28

Loading

codecov bot commented Sep 1, 2022 •

edited

Loading