Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test suite with a range of additional invalid Package URLs #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Extend test suite with a range of additional invalid Package URLs #248

wants to merge 3 commits into from

Conversation

wetterjames4
Copy link

This includes:

  • duplicated qualifiers keys
  • invalid subpaths
  • invalid types
  • invalid namespaces
  • non-unicode characters must be encoded

matt-phylum
matt-phylum reviewed Nov 8, 2023
View reviewed changes
test-suite-data.json
},
{
"description": "The package type is composed only of ASCII letters and numbers, '.', '+' and '-'",
"purl": "pkg:n@m/test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this valid according to the rules in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-phylum matt-phylum matt-phylum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wetterjames4 @matt-phylum @jkowalleck