OracleAttestation validation and follow spec #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyhodl
force-pushed
the
oracle-attestation-validation
branch
from
b13f7d3 to
d8cbe9b
Compare
|
I think the failing tests in sled are because the sled files do not have the event_id in the attestation? |
bennyhodl
force-pushed
the
oracle-attestation-validation
branch
from
d8cbe9b to
d928e67
Compare
Yeah you should be able to solve this by running the |
bennyhodl
force-pushed
the
oracle-attestation-validation
branch
from
d928e67 to
5b1f7f1
Compare
|
I added attestation validation in line with the spec Add two test of a valid attestation and an invalid attestation where signature does not match the nonce. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to OracleAttestation and adds
event_idto the messaging to follow spec.Closes #239
Closes #181