Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Github enterprise repositories #20

Conversation

d1egoaz
Copy link

@d1egoaz d1egoaz commented Feb 26, 2016

Add support for Github enterprise repositories as hostnames are different than github.com.

This is my first time writing LISP code, so I hope I'm not doing something crazy here.

@diego-alvarez-hs
Copy link

Ping @osener

@ozanmakes
Copy link
Owner

@diego-alvarez-hs sorry for taking so long to review this. I see you're taking the full url from remote.origin.url but I think more often than not non-github values will point to something like Bitbucket rather than a Github Enterprise repo.

What do you think about introducing a local variable such as github-browse-file--github-enterprise-root and using it instead of github.com if it's non-nil?

/cc @dgtized, @wjlroe, and @waymondo as you guys are probably more familiar with this package than I am at this point, and hopefully have experience with Github Enterprise :)

@d12frosted
Copy link

Also, relying on remote.origin.url is not really good, because origin is optional name.

slackorama added a commit to slackorama/github-browse-file that referenced this pull request Nov 23, 2016
@slackorama
Copy link

I took a stab at adding support for github enterprise and bitbucket...as well as the non-origin remotes.

@jjrussell
Copy link

I think I just wrote almost the same thing. Should have checked for existing PRs I guess #facepalm
#26

@d1egoaz d1egoaz closed this Nov 30, 2020
@d1egoaz d1egoaz deleted the add_suport_github_enterprise_repositories branch November 30, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants