Reduce duplication, avoid warnings #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage was removed in commit ddb56a8 ("fixes").
This check became obsolete in commit a8a30d5 ("further working towards parsing github spec") with the removal of the `self.content.len() != 1` check.
This avoids a compilation warning: > warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` > note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest > note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest > note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions > Blocking waiting for file lock on build directory
|
Thanks for putting this together. I'll have a look at this week. |
|
@augustuswm gentle ping. |
|
Apologies here! Time got away from me. I'm traveling and won't get to this until next week. But please do ping me again if I don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jessfraz could you have a look please? Best reviewed commit-by-commit.