Simplify mend region selection #1606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
force-pushed
the
mkeeter/simplify-mend
branch
from
05aef15 to
a4f7593
Compare
|
I found some more cleanup:
|
leftwo
approved these changes
Jan 17, 2025
upstairs/src/mend.rs
Outdated
| /// - Highest flush number (if generation numbers are equal) | ||
| /// - Dirty bit set (if generation and flush numbers are equal) | ||
| /// | ||
| /// If there is still a tie at the end, then the earliest source is chosen |
There was a problem hiding this comment.
What does earliest source mean here?
There was a problem hiding this comment.
Numerically lowest, I updated the comment
upstairs/src/mend.rs
Outdated
|
|
||
| info!( | ||
| log, | ||
| "find dest for source {} for extent at index {}", source, i | ||
| "find dest for source {source} for extent at index {i} => {out:?}" |
There was a problem hiding this comment.
I think we can update this message to indicate we have found our result. This was printing before we did the search, but now this log comes after we have found our answer.
There was a problem hiding this comment.
Sure, changed to "found dest ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a while staring at
find_source, convincing myself that it was just picking the highest(gen, flush, dirty)tuple. We can express it more compactly by leaning into#[derive(Ord)].Similarly,
find_destis picking clients which are not the source client, picking all such clients if the source is dirty, and clients which differ from the source otherwise.