Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python v2 in PHP images #139

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Install python v2 in PHP images #139

merged 1 commit into from
Sep 16, 2021

Conversation

phil-davis
Copy link
Contributor

PR #138 removed node, npm and yarn. Somehow we lost python v2 by doing that - I guess that it happened to be a dependency of one or more of those removed tools.

But we need python v2 for the caldav/carddav test suites. There is not yet a version of those test suites that passes with python v3.
See apple/ccs-caldavtester#39 and apple/ccs-caldavtester#40 for recent progress on that in the upstream repo.

This PR explicitly installs python v2 in the PHP images, so that we can get oC10 core CI green again.

@phil-davis
Copy link
Contributor Author

Note: I think I am right:

  • on Ubuntu 18.04 sudo apt install python gets python v2
  • on Ubuntu 20.04 sudo apt install python2 gets python v2

@phil-davis phil-davis merged commit afad154 into master Sep 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the install-old-python-2 branch September 16, 2021 11:50
@xoxys
Copy link
Contributor

xoxys commented Sep 16, 2021

Uff Python 2 EOL has been announced for so long and there is still stuff was not ported... Not really happy about this change

@phil-davis
Copy link
Contributor Author

This PR to the upstream project attempts to move to python v3: apple/ccs-caldavtester#40

I tried running with that, but still got test fails. It needs some work.

I needed to get CI green again in core. "someone" (tm) can decide if we contribute upstream or... to get these test pipelines updated to python v3.

@xoxys
Copy link
Contributor

xoxys commented Sep 16, 2021

But why have we added this test suite to CI now if we exactly know that it is python 2 which is EOL? Or how could have these test passed before we added python2 to this image? Or was the CI red for the last months?

@xoxys
Copy link
Contributor

xoxys commented Sep 16, 2021

Have not seen it before but in general, honestly I need to ask why we choose a GH project that was not updated since 3 years now.

@phil-davis
Copy link
Contributor Author

But why have we added this test suite to CI now if we exactly know that it is python 2 which is EOL? Or how could have these test passed before we added python2 to this image? Or was the CI red for the last months?

This happened today after removing node, npm and yarn from owncloudci/php. I guess that python v2 was still a dependency of something in those? And we had been "lucky" that python v2 still happened to be installed. Now we have to explicitly mention it.

@xoxys
Copy link
Contributor

xoxys commented Sep 16, 2021

Ok it gets worse and worse 🙈 Thanks for the backround

@phil-davis
Copy link
Contributor Author

Have not seen it before but in general, honestly I need to ask why we choose a GH project that was not updated since 3 years now.

Because it was chosen 3 or more years ago. "someone" (tm) chose it, and now it is rarely/not maintained!

I raised core issue owncloud/core#39249 and another "someone" can decide what to do next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants