-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install python v2 in PHP images #139
Conversation
Note: I think I am right:
|
Uff Python 2 EOL has been announced for so long and there is still stuff was not ported... Not really happy about this change |
This PR to the upstream project attempts to move to python v3: apple/ccs-caldavtester#40 I tried running with that, but still got test fails. It needs some work. I needed to get CI green again in core. "someone" (tm) can decide if we contribute upstream or... to get these test pipelines updated to python v3. |
But why have we added this test suite to CI now if we exactly know that it is python 2 which is EOL? Or how could have these test passed before we added python2 to this image? Or was the CI red for the last months? |
Have not seen it before but in general, honestly I need to ask why we choose a GH project that was not updated since 3 years now. |
This happened today after removing node, npm and yarn from |
Ok it gets worse and worse 🙈 Thanks for the backround |
Because it was chosen 3 or more years ago. "someone" (tm) chose it, and now it is rarely/not maintained! I raised core issue owncloud/core#39249 and another "someone" can decide what to do next. |
PR #138 removed node, npm and yarn. Somehow we lost python v2 by doing that - I guess that it happened to be a dependency of one or more of those removed tools.
But we need python v2 for the caldav/carddav test suites. There is not yet a version of those test suites that passes with python v3.
See apple/ccs-caldavtester#39 and apple/ccs-caldavtester#40 for recent progress on that in the upstream repo.
This PR explicitly installs python v2 in the PHP images, so that we can get oC10 core CI green again.